Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zenoh-c and zenoh-cpp to 1.1.1 #424

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Jan 16, 2025

Include some performance enhancement and bugfix in 1.1.1

On my side, there is no regression issue:
The only failure is rclcpp_action: 1 - test_client

@JEnoch
Copy link
Contributor

JEnoch commented Jan 16, 2025

This PR makes the following changes of commit ids:

It includes those notable changes:

@evshary
Copy link
Contributor Author

evshary commented Jan 17, 2025

Retested with the updated commit: still no regression failure

@evshary evshary marked this pull request as ready for review January 17, 2025 02:54
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback but good to merge otherwise.

zenoh_cpp_vendor/CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: yadunund <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>
@evshary evshary requested a review from Yadunund January 17, 2025 05:59
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with no regressions in tests observed.

@Yadunund Yadunund merged commit bda2d71 into ros2:rolling Jan 17, 2025
5 checks passed
@Yadunund
Copy link
Member

@Mergifyio backport humble jazzy

Copy link

mergify bot commented Jan 17, 2025

backport humble jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2025
* Bump zenoh-c and zenoh-cpp version.

Signed-off-by: ChenYing Kuo <[email protected]>

* Bump zenoh-c and zenoh-cpp for last minute changes before 1.1.1

* Only keep the last PR improving performance

Co-authored-by: yadunund <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: yadunund <[email protected]>
(cherry picked from commit bda2d71)
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
* Bump zenoh-c and zenoh-cpp version.

Signed-off-by: ChenYing Kuo <[email protected]>

* Bump zenoh-c and zenoh-cpp for last minute changes before 1.1.1

* Only keep the last PR improving performance

Co-authored-by: yadunund <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: yadunund <[email protected]>
(cherry picked from commit bda2d71)
@JEnoch JEnoch deleted the bump_zenoh_version_1.1.1 branch January 17, 2025 18:08
Yadunund pushed a commit that referenced this pull request Jan 17, 2025
* Bump zenoh-c and zenoh-cpp version.

Signed-off-by: ChenYing Kuo <[email protected]>

* Bump zenoh-c and zenoh-cpp for last minute changes before 1.1.1

* Only keep the last PR improving performance

Co-authored-by: yadunund <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: yadunund <[email protected]>
(cherry picked from commit bda2d71)

Co-authored-by: ChenYing Kuo (CY) <[email protected]>
Yadunund pushed a commit that referenced this pull request Jan 17, 2025
* Bump zenoh-c and zenoh-cpp version.

Signed-off-by: ChenYing Kuo <[email protected]>

* Bump zenoh-c and zenoh-cpp for last minute changes before 1.1.1

* Only keep the last PR improving performance

Co-authored-by: yadunund <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: yadunund <[email protected]>
(cherry picked from commit bda2d71)

Co-authored-by: ChenYing Kuo (CY) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants